Commit Graph
100 Commits
Author SHA1 Message Date
Davide Beatrici f061557aad Protocol.c: fix crash with OpenVPN when the certificate's common name is empty 2018-10-18 21:21:37 +02:00
Davide Beatrici 966a5e6dea Merge PR #754: Cedar/Bridge.c: fix NULL pointer dereference in GetEthDeviceHash() 2018-10-16 10:21:20 +02:00
Davide Beatrici 91c5d5feb8 Cedar/Bridge.c: fix NULL pointer dereference in GetEthDeviceHash() 2018-10-16 04:40:22 +02:00
Davide Beatrici e35e2c73d3 Merge PR #751: src/Mayaqua/MayaType.h: fix extra bracket 2018-10-14 19:40:28 +02:00
Davide Beatrici c10fdcff2c Merge PR #750: Memory.c: fix pointer cast in TrackChangeObjSize() call 2018-10-14 08:07:33 +02:00
Davide Beatrici e496f33455 Memory.c: fix pointer cast in TrackChangeObjSize() call
This commit fixes the "TrackDeleteObj: 0x12345678 is not Object!!" (where 0x12345678 is the actual address) errors with memcheck enabled.

It also fixes the following related warnings:

warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  TrackChangeObjSize((DWORD)addr, size, (DWORD)new_addr);
                     ^
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  TrackChangeObjSize((DWORD)addr, size, (DWORD)new_addr);
                                        ^
2018-10-14 07:51:53 +02:00
Davide Beatrici 9e967ce5ed Merge PR #749: MayaType.h: fix pointer casting warnings 2018-10-14 07:43:42 +02:00
Davide Beatrici ec7a9d7281 MayaType.h: fix pointer casting warnings
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define POINTER_TO_KEY(p)  ((sizeof(void *) == sizeof(UINT)) ? (UINT)(p) : HashPtrToUINT(p))
                                                                ^

warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 #define UINT64_TO_POINTER(i) ((sizeof(void *) == sizeof(UINT64)) ? (void *)(i) : (void *)((UINT)(i)))
                                                                                  ^

warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 #define POINTER_TO_UINT64(p) (((sizeof(void *) == sizeof(UINT64)) ? (UINT64)(p) : (UINT64)((UINT)(p))))
                                                                                            ^
2018-10-14 07:24:18 +02:00
Davide Beatrici 081db26359 Merge PR #748: hamcorebuilder.c: check for "_DEBUG" macro and don't enable memcheck 2018-10-14 06:17:19 +02:00
Davide Beatrici 40cca2379e hamcorebuilder.c: check for "_DEBUG" macro and don't enable memcheck 2018-10-14 03:19:12 +02:00
Davide Beatrici e3402ac676 Merge PR #741: Added OpenSSL and zlib .pdb files for .lib for Windows. 2018-10-10 06:05:21 +02:00
Davide Beatrici 76f0b2d037 BuildAll.cmd: copy "ossl_static.pdb" where the linker expects it to be 2018-10-10 05:52:54 +02:00
Davide Beatrici d291929bd2 Merge PR #740: Fix VS2017 x64 debug OpenSSL libraries name. For backward compatibility, libcrypto.lib is stored as libeay32.lib, and libssl.lib is stored as ssleay32.lib. 2018-10-10 00:47:09 +02:00
Davide Beatrici 0e22adc598 Merge PR #739: vpntest improvement: add Server Manager UI and Client Manager UI test 2018-10-09 19:47:33 +02:00
Davide Beatrici 6dcba8f492 Merge PR #738: Upgrade Windows OpenSSL to 1.1.1, and also Visual Studio 2017 static link libraries support. 2018-10-09 19:45:38 +02:00
Davide Beatrici 03d78693a3 Merge PR #735: Debug flag and test mode improvements 2018-10-08 21:00:44 +02:00
Davide Beatrici 8ddd336c38 Merge PR #736: vpntest project for programmers: runs VPN Server / VPN Client / VPN Bridge in test mode with full debug console output and memory leak checks 2018-10-08 06:33:47 +02:00
Davide Beatrici 97d7f3fb05 Add "vpntest" to CMake 2018-10-08 05:10:54 +02:00
Davide Beatrici da8cd6a10d Merge PR #734: Mayaqua/Network.c: improve RecvFrom() and RecvFrom6() 2018-10-08 03:53:10 +02:00
Davide Beatrici 9fa9f6cdc1 Mayaqua/Network.c: improve RecvFrom() and RecvFrom6()
This commit improves the RecvFrom() and RecvFrom6() functions by:
- Using the right data type for the struct size variable passed to recvfrom().
- Improving the arguments validation mechanism.
- Printing unhandled errors.
2018-10-08 03:21:10 +02:00
Davide Beatrici 66b906378f Merge PR #733: Mayaqua/OS: improve UnixGetOsInfo() so that it retrieves info on recent Linux/BSD systems 2018-10-07 04:39:09 +02:00
Davide Beatrici afe994f252 Mayaqua/OS: improve UnixGetOsInfo() so that it retrieves info on recent Linux/BSD systems 2018-10-07 01:38:02 +02:00
Davide Beatrici 335e0503c9 Mayaqua/Str: add TrimQuotes() function to remove quotes from a string 2018-10-06 22:42:29 +02:00
Davide Beatrici 9970d6f657 Mayaqua/Memory: move and adapt entry list functions from Cedar/Proto_OpenVPN 2018-10-06 22:41:35 +02:00
Davide Beatrici 2271bf5fba Merge PR #730: Add string for "IF_TYPE_PROP_VIRTUAL" network interface type 2018-10-03 09:26:05 +02:00
Davide Beatrici e02237f397 Add string for "IF_TYPE_PROP_VIRTUAL" network interface type 2018-10-03 09:10:27 +02:00
Davide Beatrici c5c1403f46 Merge PR #729: legal.txt: remove unneeded text 2018-10-03 08:40:32 +02:00
Davide Beatrici 1f4d8c5a4b legal.txt: remove unneeded text 2018-10-03 08:17:46 +02:00
Davide Beatrici 01caded489 Merge PR #728: Copy authors file into "src/bin/hamcore" automatically 2018-10-03 07:41:27 +02:00
Davide Beatrici e8050651c0 Copy authors file into "src/bin/hamcore" automatically 2018-10-03 07:24:42 +02:00
Davide Beatrici 750f583f41 Merge PR #727: AUTHORS.TXT: update contributors list using "git log --format='%aN <%aE>' | sort -f | uniq" 2018-10-03 06:18:00 +02:00
Davide Beatrici 3bd2cf34f7 AUTHORS.TXT: update contributors list using "git log --format='%aN <%aE>' | sort -f | uniq"
Email addresses ending with "@users.noreply.github.com" are replaced with the GitHub profile links.
2018-10-03 05:52:16 +02:00
Davide Beatrici 6717877231 Merge PR #726: AUTHORS.TXT: move development board members into a dedicated section 2018-10-02 02:10:59 +02:00
Davide Beatrici 69aef9c5f8 AUTHORS.TXT: move development board members into a dedicated section 2018-10-01 21:55:17 +02:00
Davide Beatrici 00f66616d2 Merge PR #721: Encrypt.c: fix MdProcess()'s HMAC implementation 2018-10-01 19:08:38 +02:00
Davide Beatrici 34f443c0c7 Merge PR #718: src/Cedar/BridgeUnix.c: resolve null pointer dereference 2018-09-29 23:30:28 +02:00
Davide Beatrici 05fecef6d8 Merge PR #725: BridgeUnix.c: enable local bridge function on all BSD systems 2018-09-28 23:11:20 +02:00
Davide Beatrici 34b8666df1 Merge PR #722: cmake: compare PROJECT_VERSION against src/CurrentBuild.txt 2018-09-28 21:00:21 +02:00
Davide Beatrici aee6084b19 BridgeUnix.c: enable local bridge function on all BSD systems 2018-09-28 20:56:10 +02:00
Davide Beatrici 53c8abfd80 Encrypt.c: fix MdProcess()'s HMAC implementation 2018-09-27 20:28:48 +02:00
Davide Beatrici 33f5de78ba Merge PR #715: src/Cedar: resolve possible null pointer dereference and silence dead code warning 2018-09-24 20:35:47 +02:00
Davide Beatrici f5bba7499d Merge PR #712: travis-ci: run stbcheck utility 2018-09-23 20:17:34 +02:00
Davide Beatrici bfb188df0d Merge PR #714: fix localization files, missing strings were taken from "en" 2018-09-23 19:40:16 +02:00
Davide Beatrici f449b0b405 Merge PR #704: vpncmd: Added information about "Disable UDP Acceleration" setting into output of AccountGet command. 2018-09-23 17:05:45 +02:00
Davide Beatrici 4c0e562019 Merge PR #713: AppVeyor: add Ubuntu 16.04 and 18.04 builds 2018-09-23 13:44:39 +02:00
Davide Beatrici a015cc04b6 AppVeyor: add Ubuntu 16.04 and 18.04 builds 2018-09-22 21:07:07 +02:00
Davide Beatrici c1d81c0940 Merge PR #695: Revamp digest functions 2018-09-22 19:18:52 +02:00
Davide Beatrici 50b42070e2 Encrypt: reorder digest functions 2018-09-22 06:47:03 +02:00
Davide Beatrici 3f5f716357 Revamp digest functions
- Hash() has been removed because it was ambiguous, Md5() and Sha0() are proper replacements.
- HMacMd5() and HMacSha1() now share a common implementation handled by the new Internal_HMac() function.
- NewMd() and MdProcess() now support plain hashing (without the key).
- NewMd(), SetMdKey() and MdProcess() now check the OpenSSL functions' return value and in case of failure a debug message is printed along with the error string, if available.
- SetMdKey()'s return value has been changed from void to bool, so that it's possible to know whether the function succeeded or not.
- MdProcess()' return value has been changed from void to UINT (unsigned int) and the function now returns the number of bytes written by HMAC_Final() or EVP_DigestFinal_ex().
2018-09-22 06:36:09 +02:00
Davide Beatrici 69b35f875a Merge PR #709: Add 'stbcheck': the STB File Multilanguage Full-Mesh Consistency Checker 2018-09-22 05:17:12 +02:00
Davide Beatrici a78bcb4f21 Merge PR #707: src/Cedar/Hub.c: resolve null pointer dereference found by coverity 2018-09-19 04:23:56 +02:00
Davide Beatrici f73d435302 Merge PR #706: BridgeUnix.c: add TAP local bridge support for FreeBSD 2018-09-18 21:40:58 +02:00
Davide Beatrici 60a2583ee4 BridgeUnix.c: add TAP local bridge support for FreeBSD 2018-09-18 01:35:23 +02:00
Davide Beatrici cb2aec1314 BridgeUnix.c: convert line endings from CRLF to LF 2018-09-18 01:32:01 +02:00
Davide Beatrici 93c962fb68 Merge PR #705: src/Cedar/Client.c: remove not needed condition 2018-09-18 00:03:21 +02:00
Davide Beatrici ca8b392dc6 Merge PR #703: Enable debug messages and memory check with debug configuration 2018-09-15 20:51:31 +02:00
Davide Beatrici 4e30a40ae1 Enable debug messages and memory check with debug configuration 2018-09-15 19:12:21 +02:00
Davide Beatrici 9a6b871a0e Merge PR #701: src/Cedar/Radius: resolve several coverity "issues" 2018-09-14 16:50:20 +02:00
Davide Beatrici ebfde9c97f Merge PR #700: CMake: fix date/time leading 0 removal regex and print both during configuration 2018-09-14 04:20:32 +02:00
Davide Beatrici 39858d7017 CMake: fix date/time leading 0 removal regex and print both during configuration
The previous regex expression removed all the 0s present in the input string, meaning that it caused the build to fail in case one of the date/time values was effectively 0.
2018-09-13 22:54:03 +02:00
Davide Beatrici 50d96aae81 Merge PR #698: Clean up Solaris device name parsing code to eliminate Coverity errors 2018-09-13 19:49:24 +02:00
Davide Beatrici 64b68c15f4 Merge PR #694: Proto_IkePacket.c: fix MD5, SHA-256, SHA-384 and SHA-512 implementation 2018-09-11 16:08:17 +02:00
Davide Beatrici 32082eb8af Proto_IkePacket.c: fix and improve IkeHMac() function
Pull request #294 added SHA-256, SHA-384, and SHA-512 support to the protocol, but part of it was removed in faee11ff09, because it caused a buffer over-read crash.

It also broke the MD5 implementation because the switch-case block didn't handle the type anymore.

This pull request fixes all the implementations and improves the IkeHMac() function by using the dedicated hashing functions.
2018-09-11 15:29:12 +02:00
Davide Beatrici 8fdd224ba7 Merge PR #690: CMake: install systemd configuration files 2018-09-10 18:17:55 +02:00
Davide Beatrici bd81c17522 Merge PR #691: Cedar: replace "Interop_" and "IPsec_" with "Proto_" in the protocol-specific source/header files' names 2018-09-10 00:59:24 +02:00
Davide Beatrici 1e6b99e3fe Cedar: replace "Interop_" and "IPsec_" with "Proto_" in the protocol-specific source/header files' names
"IPsec_IPC" has been renamed to "IPC" because it's not related to third-party protocols.
2018-09-10 00:46:29 +02:00
Davide Beatrici 553aaf9bad Travis CI: install to check if the files are copied correctly 2018-09-07 22:12:13 +02:00
Davide Beatrici afde7fb981 CMake: install systemd configuration files 2018-09-07 21:45:33 +02:00
Davide Beatrici ecfde04182 Merge PR #686: src/Cedar/Server: resolve possible null reference exception, remove unused functions, variable, duplicate assignment and conditional 2018-09-01 19:29:25 +02:00
Davide Beatrici e20bc8b162 Merge PR #685: src/Cedar/BridgeUnix.c: resolve possible null pointer dereference 2018-09-01 12:29:30 +02:00
Davide Beatrici e0c5cf9433 Merge PR #684: src/Mayaqua/Kernel: remove unused variable, functions 2018-09-01 11:44:55 +02:00
Davide Beatrici 0871c0b5d2 Merge PR #683: resolve several issues found by coverity 2018-08-30 22:26:43 +02:00
Davide Beatrici 3fcd8bc4a1 Merge PR #682: src/Cedar/Session: resolve coverity "issue", remove unused functions 2018-08-29 09:47:47 +02:00
Davide Beatrici 3f8fa9d5d9 Merge PR #673: Cedar: custom TAP interface name support for FreeBSD, function refactor 2018-08-28 14:08:03 +02:00
Davide Beatrici e14893bbdf Merge PR #678: src/Mayaqua/Unix: remove unused code, improve readability of "ifdef" 2018-08-28 09:39:54 +02:00
Davide Beatrici 3f394d23c1 Merge PR #672: Unix.c: remove macOS-specific UnixGetTick64() implementation 2018-08-28 01:27:57 +02:00
Davide Beatrici 8f53bf23e7 Merge PR #676: Divide version in multiple macros and set build info in CMake 2018-08-27 07:24:53 +02:00
Davide Beatrici 9d601c2745 CMake: set build info as compiler macros 2018-08-27 05:50:40 +02:00
Davide Beatrici c21f427fc6 Divide version in multiple macros and set default values 2018-08-27 05:44:32 +02:00
Davide Beatrici 7f9177f3d7 Merge PR #671: resolve several coverity issues 2018-08-27 01:22:27 +02:00
Davide Beatrici 1c1aa5751e Merge PR #675: Cedar: fix segmentation fault during local bridge creation on FreeBSD 2018-08-27 00:59:56 +02:00
Davide Beatrici dbb0bb83f7 Cedar: fix segmentation fault during local bridge creation on FreeBSD 2018-08-27 00:46:59 +02:00
Davide Beatrici 37ced5c479 Cedar: custom TAP interface name support for FreeBSD, function refactor
The maximum number of TAP devices to iterate through has been increased from 16 to 512.
2018-08-26 04:20:57 +02:00
Davide Beatrici e0598d747a Merge PR #670: Add TAP devices support for FreeBSD and OpenBSD 2018-08-25 14:43:42 +02:00
Davide Beatrici 19e837d81e Unix.c: remove macOS-specific UnixGetTick64() implementation
clock_gettime() was implemented in macOS 10.12.
2018-08-24 06:43:45 +02:00
Davide Beatrici 3ff5c061d7 Add TAP devices support for FreeBSD and OpenBSD
Thanks to @kennylam777 for the first implementation: https://github.com/kennylam777/SoftEtherVPN/commits/FreeBSD-TAP
2018-08-23 10:56:30 +02:00
Davide Beatrici e530932df6 Merge PR #669: src/Mayaqua/Network.c: silence coverity on "Unchecked return value" 2018-08-23 10:50:30 +02:00
Davide Beatrici 0e5d432ae4 Merge PR #667: Cedar: fix compilation on FreeBSD, broken by #337 2018-08-23 08:55:26 +02:00
Davide Beatrici 7612c2bf5d Cedar: fix compilation on FreeBSD, broken by #337 2018-08-23 04:39:13 +02:00
Davide Beatrici 2c9093b8eb Merge PR #666: Added Try+Except block for ProbeForRead 2018-08-23 04:16:05 +02:00
Davide Beatrici 2b855c8db7 Merge PR #665: src/Cedar/Client.c: remove redundant "if" statement, unused variable 2018-08-22 20:53:29 +02:00
Davide Beatrici 1b493cbf20 Merge PR #664: silence several coverity "issues" 2018-08-22 10:44:48 +02:00
Davide Beatrici 4b49540750 Merge PR #663: src/Mayaqua/Network: silence coverity, remove unused functions, variables 2018-08-21 23:53:16 +02:00
Davide Beatrici 233b525d0e Merge PR #662: Fix that virtual NAT session is closed even if data remains. 2018-08-21 13:04:06 +02:00
Davide Beatrici dbd4b9e7c2 Merge PR #661: resolve several coverity issues 2018-08-21 10:21:57 +02:00
Davide Beatrici 45d2a3ef02 Merge PR #660: resolve several coverity issues 2018-08-19 21:01:46 +02:00
Davide Beatrici 0d966755d7 Merge PR #659: resolve cosmetic coverity issues 2018-08-18 08:09:22 +02:00
Davide Beatrici daed1ad8b3 Merge PR #594: Remove SSLv3 support 2018-08-18 07:38:05 +02:00
Davide Beatrici 5f120e3c5e Merge PR #658: resolve several issues found by coverity 2018-08-17 22:11:27 +02:00
Davide Beatrici 088ed37d47 Merge PR #657: gitlab-ci: refactoring 2018-08-17 21:56:59 +02:00