Commit Graph
100 Commits
Author SHA1 Message Date
Ilya Shipitsin 272c69d35a Release v5.01.9666
Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
2018-12-04 04:14:18 +00:00
Ilya Shipitsin 971893c7b4 CI: avoid not needed builds, make AppVeyor upload src with submodules 2018-12-01 23:19:18 +05:00
Ilya Shipitsin 08465e3f39 Merge pull request #772 from davidebeatrici/http-proxy-custom-header
Merge PR #772: Add custom HTTP header feature for HTTP proxy
2018-11-30 10:22:32 +05:00
Ilya Shipitsin cbaf198bd1 Merge pull request #826 from chipitsine/issue_689
Merge PR #826: missing warning_ru.txt which caused null pointer dereference
2018-11-30 02:56:23 +05:00
Ilya Shipitsin 4be45342b7 Merge pull request #825 from chipitsine/cleanup
Merge PR #825: src/Mayaqua/Mayaqua: remove unused functions
2018-11-30 00:20:43 +05:00
Ilya Shipitsin 9e250e62be src/Mayaqua/Mayaqua: remove unused functions
found by cppcheck

[src/Mayaqua/Mayaqua.c:753]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.
[src/Mayaqua/Mayaqua.c:484]: (style) The function 'IsUnicode' is never used.
[src/Mayaqua/Mayaqua.c:438]: (style) The function 'MayaquaDotNetMode' is never used.
[src/Mayaqua/Mayaqua.c:774]: (style) The function 'PrintOsInfo' is never used.
2018-11-30 00:01:11 +05:00
Ilya Shipitsin e8ad95b083 AppVeyor: shorten artifacts path, move github token to variables 2018-11-29 22:11:47 +05:00
Ilya Shipitsin f985a50f31 quick and dirty fix for issue 689 2018-11-28 23:19:56 +05:00
Ilya Shipitsin 974f18505b v5.01.9665
Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
2018-11-28 10:34:59 +00:00
Ilya Shipitsin b65ebce4d6 Merge pull request #821 from chipitsine/master
Merge PR #821: AppVeyor refactor
2018-11-28 03:00:38 +05:00
Ilya Shipitsin 557d0a02d9 AppVeyor: do not upload ubuntu packages (we will swtich to Launchpad instead),
make vs2017 and vs2015 names different from each other, rename linux test script
2018-11-28 02:33:52 +05:00
Ilya Shipitsin bc1070a7fd travis-ci: do not do anything on tag, source is packed automatically 2018-11-28 00:34:18 +05:00
Ilya Shipitsin 70ee8abae8 Merge pull request #818 from chipitsine/cleanup
Merge PR #818: src/Mayaqua/Cfg: remove unused functions, variables
2018-11-27 02:13:10 +05:00
Ilya Shipitsin d72329c007 src/Mayaqua/Cfg: remove unused functions, variables
found by cppcheck

[src/Mayaqua/Cfg.c:669]: (style) Variable 'invalid_file' is assigned a value that is never used.
[src/Mayaqua/Cfg.c:2111]: (style) Variable 'v' is assigned a value that is never used.
[src/Mayaqua/Cfg.c:1114]: (style) The function 'CfgFolderToBufText' is never used.
[src/Mayaqua/Cfg.c:539]: (style) The function 'CfgRead' is never used.
[src/Mayaqua/Cfg.c:418]: (style) The function 'CfgSave' is never used.
[src/Mayaqua/Cfg.c:1425]: (style) The function 'CfgStrToType' is never used.
[src/Mayaqua/Cfg.c:708]: (style) The function 'CfgTest' is never used.
[src/Mayaqua/Cfg.c:704]: (style) The function 'CfgTest2' is never used.
[src/Mayaqua/Cfg.c:247]: (style) The function 'NewCfgRwW' is never used.
2018-11-27 01:52:27 +05:00
Ilya Shipitsin 4cbb8a8560 Merge pull request #817 from chipitsine/appveyor_pwsh
Merge PR #817: AppVeyor: renew github token, renamed APPVEYOR_REPO_TAG to upper case,
2018-11-27 01:20:29 +05:00
Ilya Shipitsin 6640f05233 AppVeyor: renew github token, renamed APPVEYOR_REPO_TAG to upper case,
added vpntest.exe to test memory
2018-11-27 01:01:30 +05:00
Ilya Shipitsin 2d30d718a0 travis-ci: run Coverity only after openssl is built 2018-11-20 09:34:17 +05:00
Ilya Shipitsin 3842e813d6 Release v5.01.9664
Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
2018-11-20 04:20:51 +00:00
Ilya Shipitsin 1c89bf7ede Merge pull request #811 from davidebeatrici/build-release-debug-info
Merge PR #811: Build debug info in release builds, provide PDB files on AppVeyor
2018-11-18 10:27:32 +05:00
Ilya Shipitsin 759d3f8709 gitlab-ci: enable SAST 2018-11-10 22:39:22 +05:00
Ilya Shipitsin 304893c139 src/Cedar/Protocol, src/Cedar/Session: cleanup, remove unused functions, variables,
resolve possible null pointer dereference

found by cppcheck

[src/Cedar/Protocol.c:3138] -> [src/Cedar/Protocol.c:3071]: (warning) Either the condition 's!=NULL' is redundant or there is possible null pointer dereference: s.
[src/Cedar/Protocol.c:916]: (style) Variable 'save' is assigned a value that is never used.
[src/Cedar/Protocol.c:6242]: (style) Variable 'size' is assigned a value that is never used.
[src/Cedar/Protocol.c:778]: (style) Variable 'old_disable' is assigned a value that is never used.
[src/Cedar/Protocol.c:1021]: (style) Variable 'save' is assigned a value that is never used.
[src/Cedar/Protocol.c:3708]: (style) Variable 'is_vgc' is assigned a value that is never used.
[src/Cedar/Protocol.c:5785]: (style) Variable 's' is assigned a value that is never used.
[src/Cedar/Protocol.c:6164]: (style) The function 'SocksConnectEx' is never used.
[src/Cedar/Protocol.c:907]: (style) The function 'CompareNodeInfo' is never used.
[src/Cedar/Protocol.c:6968]: (style) The function 'ProxyConnect' is never used.
[src/Cedar/Protocol.c:3986]: (style) The function 'SecureDelete' is never used.
[src/Cedar/Protocol.c:4042]: (style) The function 'SecureEnum' is never used.
[src/Cedar/Protocol.c:4127]: (style) The function 'SecureWrite' is never used.
[src/Cedar/Protocol.c:6463]: (style) The function 'SocksConnect' is never used.
[src/Cedar/Protocol.c:7185]: (style) The function 'TcpConnectEx2' is never used.
[src/Cedar/Protocol.c:7206]: (style) The function 'TcpIpConnect' is never used.
2018-11-10 14:18:18 +05:00
Ilya Shipitsin 3e042e093b travis-ci: add libressl build, make builds parallel, remove not needed brew 2018-11-10 12:32:21 +05:00
Ilya Shipitsin da13915d1e Merge pull request #804 from davidebeatrici/openbsd-aead-tag-macro-build-fix
Merge PR #804: Mayaqua/Encrypt.h: fix missing AEAD macro for OpenBSD
2018-11-09 00:23:19 +05:00
Ilya Shipitsin aa9effbf4e AppVeyor: automatically upload releases to github 2018-11-09 00:20:08 +05:00
Ilya Shipitsin 555c7c46c6 Merge pull request #802 from davidebeatrici/windows-rc-no-afsres.h
Merge PR #802: src: change "afxres.h" to "winres.h" in all resource files, to remove MFC dependency
2018-11-08 21:04:07 +05:00
Ilya Shipitsin da518914c1 release v5.01.9663
Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
2018-11-07 02:15:14 +00:00
Ilya Shipitsin 6440521f81 src/Mayaqua/Network.c: remove reccuring check
found by PVS analyzer

src/Mayaqua/Network.c	18715	err	V571 Recurring check. The 'if (u->GetNatTIpThread == NULL)' condition was already verified in line 18712.
2018-11-04 01:04:58 +05:00
Ilya Shipitsin dcc684ea28 src/Cedar/Admin.c: remove reccuring check
found by PVS analyzer

src/Cedar/Admin.c	5583	err	V571 Recurring check. The 'if (no_include)' condition was already verified in line 5581.
2018-11-04 01:02:51 +05:00
Ilya Shipitsin 87702f0f7d src/Mayaqua/OS: remove unused functions
found by cppcheck

[src/Mayaqua/OS.c:493]: (style) The function 'OSDec32' is never used.
[src/Mayaqua/OS.c:373]: (style) The function 'OSDeleteDir' is never used.
[src/Mayaqua/OS.c:393]: (style) The function 'OSFileCreate' is never used.
[src/Mayaqua/OS.c:353]: (style) The function 'OSFileDelete' is never used.
[src/Mayaqua/OS.c:383]: (style) The function 'OSFileOpen' is never used.
[src/Mayaqua/OS.c:331]: (style) The function 'OSFileRename' is never used.
[src/Mayaqua/OS.c:487]: (style) The function 'OSInc32' is never used.
[src/Mayaqua/OS.c:363]: (style) The function 'OSMakeDir' is never used.
[src/Mayaqua/OS.c:541]: (style) The function 'OSResetEvent' is never used.
2018-11-04 00:41:12 +05:00
Ilya Shipitsin f219feda2c Merge pull request #798 from chipitsine/cleanup
Merge PR #798: src/Cedar/Proto_IkePacket: remove unused functions, redundant assignment
2018-11-04 00:30:16 +05:00
Ilya Shipitsin bfe8ee8127 src/Cedar/Proto_IkePacket: remove unused functions, redundant assignments
found by cppcheck

[src/Cedar/Proto_IkePacket.c:958]: (style) The function 'IkeNewCertPayload' is never used.
[src/Cedar/Proto_IkePacket.c:942]: (style) The function 'IkeNewCertRequestPayload' is never used.
[src/Cedar/Proto_IkePacket.c:875]: (style) The function 'IkeNewNoticeErrorInvalidExchangeTypePayload' is never used.
[src/Cedar/Proto_IkePacket.c:2542]: (style) The function 'IkeNewSpi' is never used.
[src/Cedar/Proto_IkePacket.c:142]: (style) The function 'IkePhase1CryptIdToKeySize' is never used.
[src/Cedar/Proto_IkePacket.c:157]: (style) The function 'IkePhase2CryptIdToKeySize' is never used.
[src/Cedar/Proto_IkePacket.c:172]: (style) The function 'IkeStrToPhase1CryptId' is never used.
[src/Cedar/Proto_IkePacket.c:187]: (style) The function 'IkeStrToPhase1HashId' is never used.
[src/Cedar/Proto_IkePacket.c:196]: (style) The function 'IkeStrToPhase2CryptId' is never used.
[src/Cedar/Proto_IkePacket.c:211]: (style) The function 'IkeStrToPhase2HashId' is never used.
[src/Cedar/Proto_IkePacket.c:2168]: (style) Condition 'b==NULL' is always true
2018-11-04 00:13:51 +05:00
Ilya Shipitsin 90902f1364 Merge pull request #797 from chipitsine/test
Merge PR #797: AppVeyor: enable parallel builds and push systemctl log as artifact
2018-11-04 00:10:51 +05:00
Ilya Shipitsin cdc3551ad3 AppVeyor: enable parralel builds 2018-11-03 23:51:09 +05:00
Ilya Shipitsin f97a20a9cc AppVeyor: only add systemctl log when appropriate 2018-11-03 23:49:22 +05:00
Ilya Shipitsin 080edcdb81 v5.01.9662
Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
2018-10-30 16:47:37 +00:00
Ilya Shipitsin b02dd7ca53 gitlab-ci: add "vpntest" memory tests 2018-10-30 01:30:11 +05:00
Ilya Shipitsin 5f7d9b8c11 travis-ci: add "vpntest" memory checks 2018-10-29 23:21:08 +05:00
Ilya Shipitsin 3411625177 Merge pull request #785 from chipitsine/gitlab_badge
Merge PR #785: README.md: add gitlab-ci badge
2018-10-29 20:56:48 +05:00
Ilya Shipitsin 32ccec317a README.md: add gitlab-ci badge 2018-10-29 20:28:13 +05:00
Ilya Shipitsin 1af74e50ad AppVeyor: run "vpntest" for ubuntu 18.04 2018-10-29 15:53:42 +05:00
Ilya Shipitsin 8da2464831 Merge pull request #781 from chipitsine/BN_free
Merge PR #781: src/Mayaqua/Encrypt.c: fix memory leak occasionally found by valgrind
2018-10-29 14:22:45 +05:00
Ilya Shipitsin b5125e566c Merge pull request #780 from dnobori/181029_fixmemoryleak
Merge PR #780: Fix a single memory leak in loading the string table
2018-10-29 11:32:08 +05:00
Ilya Shipitsin 5e75a1fb99 src/Mayaqua/Encrypt.c: fix memory leak occasionally found by valgrind 2018-10-29 10:52:56 +05:00
Ilya Shipitsin 103b6eb194 AppVeyor: non interactive mode of journalctl 2018-10-28 20:25:56 +05:00
Ilya Shipitsin ae34141b7a Merge pull request #774 from chipitsine/master
Merge PR #774: vpntest: return non zero on invalid syntax
2018-10-27 10:16:13 +05:00
Ilya Shipitsin 292670cfa2 vpntest: return non zero on invalid syntax 2018-10-27 09:55:42 +05:00
Ilya Shipitsin 8908f4a933 app veyor: add "on_failure" linux script 2018-10-26 17:31:55 +05:00
Ilya Shipitsin 60acfae417 gitlab-ci: drop 16.04 and 18.04 builds in favour of app veyor 2018-10-26 17:24:37 +05:00
Ilya Shipitsin 092fe96676 app veyor: make it green again 2018-10-26 17:24:09 +05:00
Ilya Shipitsin 1cb225c0ba Merge pull request #771 from chipitsine/travis_fix
Merge PR #771: travis-ci: fix osx build, remove unneeded "apt" plugin (it is unused since CPack)
2018-10-25 01:03:57 +05:00
Ilya Shipitsin aff8566957 travis-ci: fix osx build, remove unneeded "apt" plugin (it is unused since CPack) 2018-10-25 00:33:58 +05:00
Ilya Shipitsin fe71635603 Merge pull request #770 from chipitsine/cmake_fix
Merge PR #770: CMake: change ${CMAKE_SOURCE_DIR}/tmp with ${CMAKE_BINARY_DIR}
2018-10-25 00:16:47 +05:00
Ilya Shipitsin 97393bbe45 CMake: change ${CMAKE_SOURCE_DIR}/tmp with ${CMAKE_BINARY_DIR} 2018-10-24 23:47:17 +05:00
Ilya Shipitsin b34d036647 Merge pull request #767 from chipitsine/cmake_fix
Merge PR #767: CMake: add dynamic libraries to RPATH
2018-10-24 13:42:27 +05:00
Ilya Shipitsin 7d1fced672 try to fix App Veyor 2018-10-24 00:33:19 +05:00
Ilya Shipitsin e50cf278cd CMake: add dynamic libraries to RPATH
Fixes #766
2018-10-24 00:32:41 +05:00
Ilya Shipitsin 5b11e6bffd fix typo issued by the previous commit 2018-10-22 22:22:08 +05:00
Ilya Shipitsin a6ac9456b5 v5.01.9661 2018-10-22 21:57:21 +05:00
Ilya Shipitsin 139fffe6e0 adjust systemd paths according to installation path 2018-10-22 10:55:12 +05:00
Ilya Shipitsin cf6eef4841 Merge pull request #757 from davidebeatrici/cmake-no-build-subdirectories
Merge PR #757: CMake: build all targets in the same directory, so that "hamcore.se2" doesn't have to be copied for each of them
2018-10-19 18:09:53 +05:00
Ilya Shipitsin 63513259c0 src/Cedar/Logging.c: clean compiler warning
warning: zero-length gnu_printf format string [-Wformat-zero-length]
2018-10-17 15:31:36 +05:00
Ilya Shipitsin 2d3469909b release v5.01.9660 2018-10-15 14:26:01 +05:00
Ilya Shipitsin 68f1260f2c src/Mayaqua/MayaType.h: fix extra bracket
reported by @paskal
2018-10-14 20:40:28 +05:00
Ilya Shipitsin c2600e64a5 Merge pull request #744 from chipitsine/12.04
Merge PR #744: gitlab-ci: enable ubuntu 12.04 builds
2018-10-12 01:16:34 +05:00
Ilya Shipitsin ec09309aa8 gitlab-ci: enable ubuntu 12.04 builds 2018-10-12 01:03:12 +05:00
Ilya Shipitsin a25fea0809 release 5.01.9659 2018-10-09 21:25:28 +05:00
Ilya Shipitsin 6144f45918 increased build number to 5.1.9658 2018-10-01 23:09:30 +05:00
Ilya Shipitsin 564ca6087f src/Mayaqua/Object.c: remove redundant conditionals
found by PVS analyzer

src/Mayaqua/Object.c	318	warn	V547 Expression 'c->Ready == 0' is always false.
src/Mayaqua/Object.c	348	warn	V547 Expression 'c->Ready == 0' is always false.
src/Mayaqua/Object.c	383	warn	V547 Expression 'c->Ready == 0' is always false.
2018-09-29 00:39:01 +05:00
Ilya Shipitsin d4ac00855b cmake: compare PROJECT_VERSION against src/CurrentBuild.txt 2018-09-28 23:38:31 +05:00
Ilya Shipitsin 3110ca530e Merge pull request #724 from dnobori/180928_fixbugs
Merge PR #724: Fix bugs reported by Coverity Scan.
2018-09-28 21:41:12 +05:00
Ilya Shipitsin 60bb1c34de src/Cedar/BridgeUnix.c: resolve null pointer dereference
found by coverity
2018-09-28 16:17:20 +05:00
Ilya Shipitsin 06c06f1db8 Merge pull request #717 from mogikanin/master
Merge PR #717: Added some output/obj folders to git ignore.
2018-09-26 18:07:49 +05:00
Ilya Shipitsin 6014ec8eb5 Merge pull request #716 from chipitsine/master
Merge PR #716: travis-ci: setup releases from tags
2018-09-26 09:51:11 +05:00
Ilya Shipitsin 433c72e978 travis-ci: setup releases from tags 2018-09-26 07:21:49 +05:00
Ilya Shipitsin 1fdc712e66 src/Cedar/Client.c: silence coverity regarding dead code 2018-09-24 11:19:54 +05:00
Ilya Shipitsin 36dbde6f32 src/Cedar/Hub.c: resolve possible null pointer dereference
found by coverity
2018-09-24 11:13:43 +05:00
Ilya Shipitsin cfd0022e61 travis-ci: run stbcheck utility 2018-09-23 22:54:57 +05:00
Ilya Shipitsin 0f77b5e30e fix localization files, missing strings were taken from "en" 2018-09-23 22:24:21 +05:00
Ilya Shipitsin 621fffbfbd src/Cedar/Hub.c: resolve null pointer dereference found by coverity,
also cleanup a code based on PVS analyzer findings

src/Cedar/Hub.c	5279	warn	V547 Expression 'e->UpdatedTime <= oldest_time' is always true.
src/Cedar/Hub.c	5840	warn	V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 5828, 5840.
2018-09-18 10:52:04 +05:00
Ilya Shipitsin f469e143fc src/Cedar/Client.c: remove not needed condition
inspired by coverity (however, coverity does not see an issue here)
2018-09-17 16:35:22 +05:00
Ilya Shipitsin 4974b2a13e src/Cedar/Radius: resolve several coverity "issues"
coverity thinks there might be null pointer dereference, make it
happier by removing check (there's a check against NULL in function itself).

condition "a.DataSize <= 1500" is always true
2018-09-14 11:05:24 +05:00
Ilya Shipitsin 8e3927f27c Merge pull request #699 from chipitsine/master
Merge PR #699: src/Cedar/Hub: resolve potential null pointer dereference, remove unused functions
2018-09-14 00:16:06 +05:00
Ilya Shipitsin 83a8b5f4aa src/Cedar/Hub: resolve potential null pointer dereference, remove unused functions
found by coverity, cppcheck

[src/Cedar/Hub.c:6663]: (style) The function 'CalcTrafficEntryDiff' is never used.
[src/Cedar/Hub.c:3387]: (style) The function 'GetSessionByPtr' is never used.
[src/Cedar/Hub.c:3139]: (style) The function 'SetSessionFirstRedirectHttpUrl' is never used.
[src/Cedar/Hub.c:3912]: (style) The function 'VgsSetEmbTag' is never used.
[src/Cedar/Hub.c:3918]: (style) The function 'VgsSetUserAgentValue' is never used.
2018-09-13 23:39:09 +05:00
Ilya Shipitsin db226eb4dd src/Cedar/Server: resolve possible null reference exception, remove unused functions, variable, duplicate assignment and conditional
found by coverity, cppcheck

[src/Cedar/Server.c:2899]: (style) Variable 'is_vgs_enabled' is assigned a value that is never used.
[src/Cedar/Server.c:3961]: (style) Variable 'id' is assigned a value that is never used.
[src/Cedar/Server.c:5723]: (style) Variable 'c' is assigned a value that is never used.
[src/Cedar/Server.c:5767]: (style) Variable 'num_connections_per_ip' is assigned a value that is never used.
[src/Cedar/Server.c:7327]: (style) Variable 'num' is assigned a value that is never used.
[src/Cedar/Server.c:8444]: (style) The function 'SiCallEnumHubBegin' is never used.
[src/Cedar/Server.c:8454]: (style) The function 'SiCallEnumHubEnd' is never used.
[src/Cedar/Server.c:9923]: (style) The function 'SiCallTaskAsyncBegin' is never used.
[src/Cedar/Server.c:9949]: (style) The function 'SiCallTaskAsyncEnd' is never used.
[src/Cedar/Server.c:10769]: (style) The function 'SiCheckCurrentRegion' is never used.
[src/Cedar/Server.c:2831]: (style) The function 'SiGetAzureEnable' is never used.
[src/Cedar/Server.c:208]: (style) The function 'SiGetServerNumUserObjects' is never used.
[src/Cedar/Server.c:2435]: (style) The function 'SiInitBridge' is never used.
[src/Cedar/Server.c:2540]: (style) The function 'SiTest' is never used.
[src/Cedar/Server.c:6707]: (style) The function 'StGetServer' is never used.
2018-09-01 17:49:08 +05:00
Ilya Shipitsin b5f391016e src/Cedar/BridgeUnix.c: resolve possible null pointer dereference
found by coverity
2018-09-01 15:00:42 +05:00
Ilya Shipitsin 56681d41a0 src/Mayaqua/Kernel: remove unused variable, functions
found by cppcheck

[src/Mayaqua/Kernel.c:1199]: (style) Variable 'new_thread' is assigned a value that is never used.
[src/Mayaqua/Kernel.c:385]: (style) The function 'DelThreadFromThreadList' is never used.
[src/Mayaqua/Kernel.c:1726]: (style) The function 'GetCurrentLocale' is never used.
[src/Mayaqua/Kernel.c:562]: (style) The function 'GetHomeDir' is never used.
[src/Mayaqua/Kernel.c:1644]: (style) The function 'GetSpanStr' is never used.
[src/Mayaqua/Kernel.c:1695]: (style) The function 'GetSpanStrEx' is never used.
[src/Mayaqua/Kernel.c:950]: (style) The function 'GetTimeStr64' is never used.
[src/Mayaqua/Kernel.c:909]: (style) The function 'GetTimeStrEx64' is never used.
[src/Mayaqua/Kernel.c:1924]: (style) The function 'System64ToTime' is never used.
[src/Mayaqua/Kernel.c:1900]: (style) The function 'TimeToSystem64' is never used.
[src/Mayaqua/Kernel.c:470]: (style) The function 'WaitAllThreadsWillBeStopped' is never used.
[src/Mayaqua/Kernel.c:1478]: (style) The function 'GetTimeStr' is never used.
2018-09-01 10:25:09 +05:00
Ilya Shipitsin 156166dba1 src/Cedar/Hub: resolve null pointer dereference found by coverity 2018-08-31 00:59:06 +05:00
Ilya Shipitsin 9675b0eb6d src/Cedar/IPsec_EtherIP: resolve "Identical code for different branches"
found by coverity
2018-08-31 00:56:00 +05:00
Ilya Shipitsin 2c2caa81bc src/Cedar/Interop_OpenVPN: resolve coverity "issue"
coverity thinks there might be null pointer dereference. we can
safely remove a check here, because OvsFreePacket checks for null
itself
2018-08-31 00:50:53 +05:00
Ilya Shipitsin c81dfc0e58 src/Cedar/Session: modify code to avoid "Identical code for different branches", remove unused functions.
found by coverity, cppcheck

[src/Cedar/Session.c:1856]: (style) The function 'CompareSession' is never used.
[src/Cedar/Session.c:2384]: (style) The function 'DebugPrintSessionKey' is never used.
[src/Cedar/Session.c:2102]: (style) The function 'GetSessionFromKey32' is never used.
2018-08-29 12:36:09 +05:00
Ilya Shipitsin eb7a8aa517 Merge pull request #680 from Olim98/patch-1
Merge PR #679: Add Russian language to translate.txt
2018-08-29 10:48:10 +05:00
Ilya Shipitsin eb0edeb1db Merge pull request #679 from Olim98/patch-2
Merge PR #679: Partial translation to Russian
2018-08-28 22:00:58 +05:00
Ilya Shipitsin a55a3b50e8 src/Mayaqua/Unix: remove unused code, improve readability of "ifdef"
refactoring was discussed in PR#672
2018-08-28 10:21:36 +05:00
Ilya Shipitsin dcd03476c4 src/Cedar/Connection: resolve null pointer dereference found by coverity,
remove unused function

[src/Cedar/Connection.c:2861]: (style) The function 'InitTcpSockRc4Key' is never used.
2018-08-24 15:26:14 +05:00
Ilya Shipitsin a58d26f125 src/Cedar/IPsec_IKE.c: resolve null pointer dereference found by coverity,
remove unused variable

[src/Cedar/IPsec_IKE.c:4332] -> [src/Cedar/IPsec_IKE.c:4332]: (style) Same expression on both sides of '||'.
[src/Cedar/IPsec_IKE.c:1665]: (style) Variable 'zero' is assigned a value that is never used.
2018-08-24 15:25:34 +05:00
Ilya Shipitsin 2f7d71a567 src/Cedar/Cedar.c: resolve "Identical code for different branches", remove unused functions
found by coverity, cppcheck

[src/Cedar/Cedar.c:1605]: (style) The function 'EnableDebugLog' is never used.
[src/Cedar/Cedar.c:858]: (style) The function 'GetUnestablishedConnections' is never used.
[src/Cedar/Cedar.c:652]: (style) The function 'InitHiddenPassword' is never used.
[src/Cedar/Cedar.c:633]: (style) The function 'IsHiddenPasswordChanged' is never used.
[src/Cedar/Cedar.c:393]: (style) The function 'IsInNoSsl' is never used.
[src/Cedar/Cedar.c:1785]: (style) The function 'IsLaterBuild' is never used.
2018-08-24 15:23:45 +05:00
Ilya Shipitsin ddd0c96d46 src/Mayaqua/Network.c: silence coverity on "Unchecked return value" 2018-08-23 13:36:38 +05:00
Ilya Shipitsin a2d5fb7015 src/Cedar/Client.c: remove redundant "if" statement, unused variable
found by coverity, cppcheck

[src/Cedar/Client.c:9094]: (style) Unused variable: i
[src/Cedar/Client.c:500] -> [src/Cedar/Client.c:503]: (style) Variable 'ret' is reassigned a value before the old one has been used.
2018-08-22 20:58:03 +05:00
Ilya Shipitsin e8c6e2c1d9 src/Cedar/Client.c, src/Mayaqua/Network.c, src/Mayaqua/Unix.c: silence coverity 2018-08-22 10:40:13 +05:00
Ilya Shipitsin 5ecc80a14e src/Cedar/Virtual: coverity suspects null pointer dereference here
however, both Cancel() and ReleaseCancel() checks for NULL themselves,
so we can remove this check
2018-08-22 10:33:29 +05:00