From fd16f73c0e05fc581a8e8bd5dbebd9e4ebd29c8c Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipitsine@gmail.com>
Date: Mon, 13 Aug 2018 15:37:11 +0500
Subject: [PATCH 1/4] src/Mayaqua/Tick64.c: reorder guards in order to silence
 coverity

---
 src/Mayaqua/Tick64.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/Mayaqua/Tick64.c b/src/Mayaqua/Tick64.c
index 92f74c0b..9ec568ae 100644
--- a/src/Mayaqua/Tick64.c
+++ b/src/Mayaqua/Tick64.c
@@ -133,11 +133,10 @@ static EVENT *halt_tick_event = NULL;
 // Get the high-resolution time
 UINT64 TickHighres64()
 {
-	UINT64 ret = 0;
 
 #ifdef	OS_WIN32
 
-	ret = (UINT64)(MsGetHiResTimeSpan(MsGetHiResCounter()) * 1000.0f);
+	return (UINT64)(MsGetHiResTimeSpan(MsGetHiResCounter()) * 1000.0f);
 
 #else	// OS_WIN32
 
@@ -145,7 +144,6 @@ UINT64 TickHighres64()
 
 #endif	// OS_WIN32
 
-	return ret;
 }
 
 // Convert the Tick value to time

From 937da4a74655d37369609b420c1d2363f2914f03 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipitsine@gmail.com>
Date: Mon, 13 Aug 2018 15:39:29 +0500
Subject: [PATCH 2/4] src/Cedar/EtherLog.c: resolve possible null dereference
 found by coverity

---
 src/Cedar/EtherLog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Cedar/EtherLog.c b/src/Cedar/EtherLog.c
index c32421e7..26ddf654 100644
--- a/src/Cedar/EtherLog.c
+++ b/src/Cedar/EtherLog.c
@@ -276,7 +276,7 @@ UINT EcConnect(char *host, UINT port, char *password, RPC **rpc)
 // RPC server function
 PACK *ElRpcServer(RPC *r, char *name, PACK *p)
 {
-	EL *e = (EL *)r->Param;
+	EL *e;
 	PACK *ret;
 	UINT err;
 	bool ok;
@@ -286,6 +286,7 @@ PACK *ElRpcServer(RPC *r, char *name, PACK *p)
 		return NULL;
 	}
 
+	e = (EL *)r->Param;
 	ret = NewPack();
 	err = ERR_NO_ERROR;
 	ok = false;

From ff1470cdceb25446d66916e48a1f31c59e638087 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipitsine@gmail.com>
Date: Mon, 13 Aug 2018 15:40:17 +0500
Subject: [PATCH 3/4] src/Cedar/Nat.c: resolve possible null dereference found
 by coverity

---
 src/Cedar/Nat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Cedar/Nat.c b/src/Cedar/Nat.c
index 59d0d8a0..7269e6b7 100644
--- a/src/Cedar/Nat.c
+++ b/src/Cedar/Nat.c
@@ -299,7 +299,7 @@ RPC *NatAdminConnect(CEDAR *cedar, char *hostname, UINT port, void *hashed_passw
 // RPC server function
 PACK *NiRpcServer(RPC *r, char *name, PACK *p)
 {
-	NAT *n = (NAT *)r->Param;
+	NAT *n;
 	PACK *ret;
 	UINT err;
 	bool ok;
@@ -309,6 +309,7 @@ PACK *NiRpcServer(RPC *r, char *name, PACK *p)
 		return NULL;
 	}
 
+	n = (NAT *)r->Param;
 	ret = NewPack();
 	err = ERR_NO_ERROR;
 	ok = false;

From eb4efe3f1b833b44fdddc507ded5558838158b8d Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipitsine@gmail.com>
Date: Mon, 13 Aug 2018 15:40:45 +0500
Subject: [PATCH 4/4] src/Cedar/Session.c: avoid unintentional integer overflow
 found by coverity

---
 src/Cedar/Session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Cedar/Session.c b/src/Cedar/Session.c
index 451839a9..5bd5fa19 100644
--- a/src/Cedar/Session.c
+++ b/src/Cedar/Session.c
@@ -1006,7 +1006,7 @@ void ClientAdditionalConnectChance(SESSION *s)
 				(s->NextConnectionTime <= now))
 			{
 				// Start the work to put an additional connection
-				s->NextConnectionTime = now + (UINT64)(s->ClientOption->AdditionalConnectionInterval * 1000);
+				s->NextConnectionTime = now + s->ClientOption->AdditionalConnectionInterval * (UINT64)1000U;
 				SessionAdditionalConnect(s);
 			}
 			else