From ad41d54b29dedf27d029e565b7875827e4253195 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 12 Aug 2018 16:03:10 +0500 Subject: [PATCH] src/Cedar/Command.c: remove logically dead code found by coverity --- src/Cedar/Command.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/Cedar/Command.c b/src/Cedar/Command.c index 7f380b33..2fbbddd5 100644 --- a/src/Cedar/Command.c +++ b/src/Cedar/Command.c @@ -19678,30 +19678,17 @@ UINT PsDhcpDisable(CONSOLE *c, char *cmd_name, wchar_t *str, void *param) } else { - bool ok = true; - t.UseDhcp = false; - if (ok == false) + ret = ScSetSecureNATOption(ps->Rpc, &t); + + if (ret != ERR_NO_ERROR) { - // Parameter is invalid - ret = ERR_INVALID_PARAMETER; + // An error has occured CmdPrintError(c, ret); FreeParamValueList(o); return ret; } - else - { - ret = ScSetSecureNATOption(ps->Rpc, &t); - - if (ret != ERR_NO_ERROR) - { - // An error has occured - CmdPrintError(c, ret); - FreeParamValueList(o); - return ret; - } - } } FreeParamValueList(o);