1
0
mirror of https://github.com/SoftEtherVPN/SoftEtherVPN.git synced 2025-07-08 00:34:57 +03:00

Merge pull request #275 from chipitsine/master

cppcheck findings
This commit is contained in:
Moataz Elmasry
2018-02-01 00:06:08 +01:00
committed by GitHub
7 changed files with 21 additions and 11 deletions

View File

@ -410,11 +410,12 @@ PACK *AdminDispatch(RPC *rpc, char *name, PACK *p)
server = a->Server;
if (server != NULL)
if (server == NULL)
{
cedar = server->Cedar;
return NULL;
}
cedar = server->Cedar;
Lock(cedar->CedarSuperLock);
if (true)

View File

@ -6652,7 +6652,10 @@ SOCK *SocksConnectEx2(CONNECTION *c, char *proxy_host_name, UINT proxy_port,
if (c == NULL || proxy_host_name == NULL || proxy_port == 0 || server_host_name == NULL
|| server_port == 0)
{
c->Err = ERR_PROXY_CONNECT_FAILED;
if (c != NULL)
{
c->Err = ERR_PROXY_CONNECT_FAILED;
}
return NULL;
}
@ -6846,7 +6849,10 @@ SOCK *ProxyConnectEx2(CONNECTION *c, char *proxy_host_name, UINT proxy_port,
if (c == NULL || proxy_host_name == NULL || proxy_port == 0 || server_host_name == NULL ||
server_port == 0)
{
c->Err = ERR_PROXY_CONNECT_FAILED;
if( c != NULL)
{
c->Err = ERR_PROXY_CONNECT_FAILED;
}
return NULL;
}
if (username != NULL && password != NULL &&

View File

@ -326,7 +326,7 @@ static wchar_t *WpListener(WEBUI *wu, LIST *params)
WU_CONTEXT *context = WuGetContext(wu->Contexts, sessionkey);
char *cmd = (char*)StrMapSearch(params, "CMD");
RPC_LISTENER t;
UINT retcode;
UINT retcode = ERR_NO_ERROR;
if(context == NULL)
{