From a08857150b6be7b4dec519f6810b5395e361e305 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 24 Feb 2021 00:04:52 +0500 Subject: [PATCH] cleanup redundant check found by Coverity CID 287561 (#1 of 1): Array compared against 0 (NO_EFFECT)array_null: Comparing an array to null is not useful: src == NULL, since the test will always evaluate as true. Was src formerly declared as a pointer? 3748 if (cedar == NULL || src == NULL || dst == NULL) 3749 { 3750 return false; 3751 } --- src/Cedar/Proto_PPP.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Cedar/Proto_PPP.c b/src/Cedar/Proto_PPP.c index 60103db6..ef27ed3a 100644 --- a/src/Cedar/Proto_PPP.c +++ b/src/Cedar/Proto_PPP.c @@ -3745,7 +3745,7 @@ bool PPPParseUsername(CEDAR *cedar, char *src_username, ETHERIP_ID *dst) char src[MAX_SIZE]; // Validate arguments Zero(dst, sizeof(ETHERIP_ID)); - if (cedar == NULL || src == NULL || dst == NULL) + if (cedar == NULL || dst == NULL) { return false; }