From 4974b2a13e0d12794b68846e6a7252668c912af6 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 14 Sep 2018 11:05:24 +0500 Subject: [PATCH] src/Cedar/Radius: resolve several coverity "issues" coverity thinks there might be null pointer dereference, make it happier by removing check (there's a check against NULL in function itself). condition "a.DataSize <= 1500" is always true --- src/Cedar/Radius.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/Cedar/Radius.c b/src/Cedar/Radius.c index 5074e3c2..5ce158bb 100644 --- a/src/Cedar/Radius.c +++ b/src/Cedar/Radius.c @@ -1577,7 +1577,7 @@ RADIUS_PACKET *ParseRadiusPacket(void *data, UINT size) goto LABEL_ERROR; } - if (a.Type == RADIUS_ATTRIBUTE_EAP_MESSAGE && a.DataSize >= 5 && a.DataSize <= 1500) + if (a.Type == RADIUS_ATTRIBUTE_EAP_MESSAGE && a.DataSize >= 5) { UINT sz_tmp = Endian16(((EAP_MESSAGE *)a.Data)->Len); @@ -1691,15 +1691,8 @@ RADIUS_PACKET *ParseRadiusPacket(void *data, UINT size) LABEL_ERROR: - if (p != NULL) - { - FreeRadiusPacket(p); - } - - if (buf != NULL) - { - FreeBuf(buf); - } + FreeRadiusPacket(p); + FreeBuf(buf); return NULL; }