From 6440521f8103f929c6deabc75a7122616b5ee377 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 4 Nov 2018 01:04:58 +0500 Subject: [PATCH] src/Mayaqua/Network.c: remove reccuring check found by PVS analyzer src/Mayaqua/Network.c 18715 err V571 Recurring check. The 'if (u->GetNatTIpThread == NULL)' condition was already verified in line 18712. --- src/Mayaqua/Network.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/Mayaqua/Network.c b/src/Mayaqua/Network.c index 9556ce26..0f31ab15 100644 --- a/src/Mayaqua/Network.c +++ b/src/Mayaqua/Network.c @@ -18711,16 +18711,9 @@ LABEL_RESTART: // Create a thread to get a NAT-T IP address if necessary if (u->GetNatTIpThread == NULL) { - // Create a thread to get a NAT-T IP address if necessary - if (u->GetNatTIpThread == NULL) - { - char natt_hostname[MAX_SIZE]; - - RUDPGetRegisterHostNameByIP(natt_hostname, sizeof(natt_hostname), NULL); - - u->GetNatTIpThread = NewQueryIpThread(natt_hostname, QUERYIPTHREAD_INTERVAL_LAST_OK, QUERYIPTHREAD_INTERVAL_LAST_NG); - } - + char natt_hostname[MAX_SIZE]; + RUDPGetRegisterHostNameByIP(natt_hostname, sizeof(natt_hostname), NULL); + u->GetNatTIpThread = NewQueryIpThread(natt_hostname, QUERYIPTHREAD_INTERVAL_LAST_OK, QUERYIPTHREAD_INTERVAL_LAST_NG); GetQueryIpThreadResult(u->GetNatTIpThread, &nat_t_ip); } }