From 5c346ef96e44e075fade0219bf3b8e5d1ee84011 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 24 Feb 2021 00:35:17 +0500 Subject: [PATCH] remove dead code found by Coverity 2575 // Address at_least: At condition size < 1U, the value of size must be at least 1. cannot_single: At condition size < 1U, the value of size cannot be equal to 0. dead_error_condition: The condition size < 1U cannot be true. 2576 if (size < 1) 2577 { CID 287533 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: goto LABEL_ERROR;. 2578 goto LABEL_ERROR; 2579 } --- src/Cedar/Proto_PPP.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Cedar/Proto_PPP.c b/src/Cedar/Proto_PPP.c index 6ad76a2e..9542cf09 100644 --- a/src/Cedar/Proto_PPP.c +++ b/src/Cedar/Proto_PPP.c @@ -2573,10 +2573,6 @@ PPP_PACKET *ParsePPPPacket(void *data, UINT size) buf = (UCHAR *)data; // Address - if (size < 1) - { - goto LABEL_ERROR; - } if (buf[0] != 0xff) { goto LABEL_ERROR;