AMajor/SoftEtherVPN
1
0
Fork 0
mirror of https://github.com/SoftEtherVPN/SoftEtherVPN.git synced 2024-11-06 09:40:41 +03:00
Code Releases Activity

cppcheck issues:

Browse Source 
[src/Cedar/Virtual.c:2389] -> [src/Cedar/Virtual.c:2398]: (warning) Either the condition 'a==0' is redundant or there is possible null pointer dereference: a.
[src/Cedar/Virtual.c:4000] -> [src/Cedar/Virtual.c:4004]: (warning) Either the condition 'n==0' is redundant or there is possible null pointer dereference: n.
[src/Cedar/Virtual.c:4203] -> [src/Cedar/Virtual.c:4207]: (warning) Either the condition 'n==0' is redundant or there is possible null pointer dereference: n.
This commit is contained in:
Ilya Shipitsin 2016-04-30 00:03:35 +05:00
parent 84f95447a3
commit 556ea647e3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Cedar/Virtual.c
View File

@ -2386,7 +2386,6 @@ bool NnTestConnectivity(NATIVE_STACK *a, TUBE *halt_tube)
UINT64 next_send_tick = 0; UINT64 next_send_tick = 0;
UINT64 giveup_time; UINT64 giveup_time;
IPC *ipc; IPC *ipc;
UINT src_port = NnGenSrcPort(a->IsIpRawMode);
INTERRUPT_MANAGER *interrupt; INTERRUPT_MANAGER *interrupt;
TUBE *tubes[3]; TUBE *tubes[3];
UINT num_tubes = 0; UINT num_tubes = 0;
@ -2399,6 +2398,7 @@ bool NnTestConnectivity(NATIVE_STACK *a, TUBE *halt_tube)
{ {
return false; return false;
} }
UINT src_port = NnGenSrcPort(a->IsIpRawMode);
Copy(&using_dns, &a->DnsServerIP, sizeof(IP)); Copy(&using_dns, &a->DnsServerIP, sizeof(IP));
@ -3997,7 +3997,6 @@ bool NatTransactIcmp(VH *v, NAT_ENTRY *n)
void *buf; void *buf;
UINT recv_size; UINT recv_size;
BLOCK *block; BLOCK *block;
UINT dest_port = n->DestPort;
IP dest_ip; IP dest_ip;
UINT num_ignore_errors = 0; UINT num_ignore_errors = 0;
// Validate arguments // Validate arguments
@ -4005,6 +4004,7 @@ bool NatTransactIcmp(VH *v, NAT_ENTRY *n)
{ {
return true; return true;
} }
UINT dest_port = n->DestPort;
if (n->DisconnectNow) if (n->DisconnectNow)
{ {
@ -4200,7 +4200,6 @@ bool NatTransactUdp(VH *v, NAT_ENTRY *n)
void *buf; void *buf;
UINT recv_size; UINT recv_size;
BLOCK *block; BLOCK *block;
UINT dest_port = n->DestPort;
IP dest_ip; IP dest_ip;
UINT num_ignore_errors; UINT num_ignore_errors;
// Validate arguments // Validate arguments
@ -4208,6 +4207,7 @@ bool NatTransactUdp(VH *v, NAT_ENTRY *n)
{ {
return true; return true;
} }
UINT dest_port = n->DestPort;
if (n->DisconnectNow) if (n->DisconnectNow)
{ {