AMajor/SoftEtherVPN
1
0
Fork 0
mirror of https://github.com/SoftEtherVPN/SoftEtherVPN.git synced 2025-11-19 18:01:33 +03:00
Code Releases Activity

src/Cedar/Admin.c: remove redundant check

Browse Source 
found by Coverity

*** CID 341551:  Incorrect expression  (NO_EFFECT)
/src/Cedar/Admin.c: 414 in AdminWebHandleFileRequest()
408     // Handle the file request
409     bool AdminWebHandleFileRequest(ADMIN *a, CONNECTION *c, SOCK *s, HTTP_HEADER *h, char *url_src, char *query_string, char *virtual_root_dir, char *physical_root_dir)
410     {
411             bool ret = false;
412             char url[MAX_PATH];
413             UINT i, len;
>>>     CID 341551:  Incorrect expression  (NO_EFFECT)
>>>     Comparing an array to null is not useful: "url == NULL", since the test will always evaluate as true.
414             if (a == NULL || c == NULL || s == NULL || h == NULL || url == NULL || query_string == NULL ||
415                     virtual_root_dir == NULL || physical_root_dir == NULL)
416             {
417                     return false;
418             }
419
This commit is contained in:
Ilya Shipitsin
2019-07-06 10:22:44 +05:00
parent 17a04b4387
commit 47ad2328c0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Cedar/Admin.c
View File

@ -411,7 +411,7 @@ bool AdminWebHandleFileRequest(ADMIN *a, CONNECTION *c, SOCK *s, HTTP_HEADER *h,
bool ret = false; bool ret = false;
char url[MAX_PATH]; char url[MAX_PATH];
UINT i, len; UINT i, len;
if (a == NULL || c == NULL || s == NULL || h == NULL || url == NULL || query_string == NULL || if (a == NULL || c == NULL || s == NULL || h == NULL || query_string == NULL ||
virtual_root_dir == NULL || physical_root_dir == NULL) virtual_root_dir == NULL || physical_root_dir == NULL)
{ {
return false; return false;