From 2c2caa81bca0ec13a53c0ccb65b8cf56a571f43b Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 31 Aug 2018 00:50:53 +0500 Subject: [PATCH] src/Cedar/Interop_OpenVPN: resolve coverity "issue" coverity thinks there might be null pointer dereference. we can safely remove a check here, because OvsFreePacket checks for null itself --- src/Cedar/Interop_OpenVPN.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Cedar/Interop_OpenVPN.c b/src/Cedar/Interop_OpenVPN.c index 854e1ba0..9343d9d1 100644 --- a/src/Cedar/Interop_OpenVPN.c +++ b/src/Cedar/Interop_OpenVPN.c @@ -1661,10 +1661,7 @@ OPENVPN_PACKET *OvsParsePacket(UCHAR *data, UINT size) LABEL_ERROR: Debug("OvsParsePacket Error.\n"); - if (ret != NULL) - { - OvsFreePacket(ret); - } + OvsFreePacket(ret); return NULL; }