AMajor/SoftEtherVPN
1
0
Fork 0
mirror of https://github.com/SoftEtherVPN/SoftEtherVPN.git synced 2024-11-22 17:39:53 +03:00
Code Releases Activity

Cedar/Proto.c: fix wrong NULL check in ProtoHandleDatagrams(), found by Coverity

Browse Source 
*** CID 358434: Null pointer dereferences (REVERSE_INULL)
 /src/Cedar/Proto.c: 451 in ProtoHandleDatagrams()
 445   void ProtoHandleDatagrams(UDPLISTENER *listener, LIST *datagrams)
 446   {
 447       UINT i;
 448       HASH_LIST *sessions;
 449       PROTO *proto = listener->Param;
 450
 >>>   CID 358434: Null pointer dereferences (REVERSE_INULL)
 >>>   Null-checking "listener" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
 451       if (proto == NULL || listener == NULL || datagrams == NULL)
 452       {
 453           return;
 454       }
 455
 456       sessions = proto->Sessions;
This commit is contained in:
Davide Beatrici 2020-05-12 21:26:42 +02:00
parent 1d5ded9388
commit 20bbe325fe
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Cedar/Proto.c
View File

@ -445,14 +445,15 @@ bool ProtoHandleConnection(PROTO *proto, SOCK *sock)
void ProtoHandleDatagrams(UDPLISTENER *listener, LIST *datagrams) void ProtoHandleDatagrams(UDPLISTENER *listener, LIST *datagrams)
{ {
UINT i; UINT i;
PROTO *proto;
HASH_LIST *sessions; HASH_LIST *sessions;
PROTO *proto = listener->Param;
if (proto == NULL || listener == NULL || datagrams == NULL) if (listener == NULL || datagrams == NULL)
{ {
return; return;
} }
proto = listener->Param;
sessions = proto->Sessions; sessions = proto->Sessions;
for (i = 0; i < LIST_NUM(datagrams); ++i) for (i = 0; i < LIST_NUM(datagrams); ++i)