From a71589e027bf892505c7f1fb10e1aed9b8e7d6ab Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 18 Aug 2018 10:25:30 +0500 Subject: [PATCH] src/Cedar/EtherLog: silence coverity, remove unused functions found by coverity, cppcheck [src/Cedar/EtherLog.c:327]: (style) The function 'EcAddLicenseKey' is never used. [src/Cedar/EtherLog.c:385]: (style) The function 'ElCheckLicense' is never used. --- src/Cedar/EtherLog.c | 10 ++-------- src/Cedar/EtherLog.h | 2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/Cedar/EtherLog.c b/src/Cedar/EtherLog.c index dc593d21..b0f2adbe 100644 --- a/src/Cedar/EtherLog.c +++ b/src/Cedar/EtherLog.c @@ -240,7 +240,7 @@ UINT EcConnect(char *host, UINT port, char *password, RPC **rpc) // Receive the random number Zero(rand, sizeof(rand)); - RecvAll(s, rand, sizeof(rand), false); + (void)RecvAll(s, rand, sizeof(rand), false); SecurePassword(response, password_hash, rand); // Send a response @@ -324,7 +324,6 @@ DECLARE_SC("GetDevice", RPC_ADD_DEVICE, EcGetDevice, InRpcAddDevice, OutRpcAddDe DECLARE_SC_EX("EnumDevice", RPC_ENUM_DEVICE, EcEnumDevice, InRpcEnumDevice, OutRpcEnumDevice, FreeRpcEnumDevice) DECLARE_SC("SetPassword", RPC_SET_PASSWORD, EcSetPassword, InRpcSetPassword, OutRpcSetPassword) DECLARE_SC_EX("EnumAllDevice", RPC_ENUM_DEVICE, EcEnumAllDevice, InRpcEnumDevice, OutRpcEnumDevice, FreeRpcEnumDevice) -DECLARE_SC("AddLicenseKey", RPC_TEST, EcAddLicenseKey, InRpcTest, OutRpcTest) DECLARE_SC("DelLicenseKey", RPC_TEST, EcDelLicenseKey, InRpcTest, OutRpcTest) DECLARE_SC_EX("EnumLicenseKey", RPC_ENUM_LICENSE_KEY, EcEnumLicenseKey, InRpcEnumLicenseKey, OutRpcEnumLicenseKey, FreeRpcEnumLicenseKey) DECLARE_SC("GetLicenseStatus", RPC_EL_LICENSE_STATUS, EcGetLicenseStatus, InRpcElLicenseStatus, OutRpcElLicenseStatus) @@ -381,11 +380,6 @@ UINT EtGetBridgeSupport(EL *a, RPC_BRIDGE_SUPPORT *t) return ERR_NO_ERROR; } -// Update the status by checking the all licenses -void ElCheckLicense(EL_LICENSE_STATUS *st, LICENSE *e) -{ -} - // Save by analyzing the status of the current license void ElParseCurrentLicenseStatus(LICENSE_SYSTEM *s, EL_LICENSE_STATUS *st) { @@ -755,7 +749,7 @@ void ElListenerProc(THREAD *thread, void *param) // Receive a response SecurePassword(pass1, e->HashedPassword, rand); Zero(pass2, sizeof(pass2)); - RecvAll(s, pass2, sizeof(pass2), false); + (void)RecvAll(s, pass2, sizeof(pass2), false); if (Cmp(pass1, pass2, SHA1_SIZE) != 0) { diff --git a/src/Cedar/EtherLog.h b/src/Cedar/EtherLog.h index f05647be..ba7e63ca 100644 --- a/src/Cedar/EtherLog.h +++ b/src/Cedar/EtherLog.h @@ -225,7 +225,6 @@ void ElStartListener(EL *e); void ElStopListener(EL *e); void ElListenerProc(THREAD *thread, void *param); PACK *ElRpcServer(RPC *r, char *name, PACK *p); -void ElCheckLicense(EL_LICENSE_STATUS *st, LICENSE *e); void ElParseCurrentLicenseStatus(LICENSE_SYSTEM *s, EL_LICENSE_STATUS *st); bool ElIsBetaExpired(); @@ -251,7 +250,6 @@ UINT EcGetDevice(RPC *r, RPC_ADD_DEVICE *t); UINT EcEnumDevice(RPC *r, RPC_ENUM_DEVICE *t); UINT EcEnumAllDevice(RPC *r, RPC_ENUM_DEVICE *t); UINT EcSetPassword(RPC *r, RPC_SET_PASSWORD *t); -UINT EcAddLicenseKey(RPC *r, RPC_TEST *t); UINT EcDelLicenseKey(RPC *r, RPC_TEST *t); UINT EcEnumLicenseKey(RPC *r, RPC_ENUM_LICENSE_KEY *t); UINT EcGetLicenseStatus(RPC *r, RPC_EL_LICENSE_STATUS *t);