From 051e6764cd2d4dba844fe44a9c6779dcc40bade7 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 14 Jan 2023 16:55:53 +0600 Subject: [PATCH] src/Cedar/Server.c: mute Coverity warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CID 375156: Uninitialized scalar variable (UNINIT)5. uninit_use_in_call: Using uninitialized element of array ticket when calling BinToStr. 8135        BinToStr(ticket_str, sizeof(ticket_str), ticket, SHA1_SIZE); --- src/Cedar/Server.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Cedar/Server.c b/src/Cedar/Server.c index 943b8870..fbb0fe11 100644 --- a/src/Cedar/Server.c +++ b/src/Cedar/Server.c @@ -8130,13 +8130,11 @@ PACK *SiCalledCreateTicket(SERVER *s, PACK *p) if (PackGetDataSize(p, "Ticket") == SHA1_SIZE) { PackGetData(p, "Ticket", ticket); + BinToStr(ticket_str, sizeof(ticket_str), ticket, SHA1_SIZE); + SLog(s->Cedar, "LS_TICKET_2", hubname, username, realusername, sessionname, + ticket_str, TICKET_EXPIRES / 1000); } - BinToStr(ticket_str, sizeof(ticket_str), ticket, SHA1_SIZE); - - SLog(s->Cedar, "LS_TICKET_2", hubname, username, realusername, sessionname, - ticket_str, TICKET_EXPIRES / 1000); - // Get the HUB h = GetHub(s->Cedar, hubname); if (h == NULL)